amechama/sharkey
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Refactor: Switch Settings index page to setup sugar (#8374)

Browse Source 
* refactor(client): Make Settings index page use <script setup>

* chore(client): address review comments
This commit is contained in:
Andreas Nedbal 2022-03-06 11:17:43 +01:00 committed by GitHub
parent 2442592ef1
commit 939773a5b9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 209 additions and 231 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

84
packages/client/src/pages/settings/index.vue
View File

@ -22,8 +22,8 @@
</MkSpacer> </MkSpacer>
</template> </template>
<script lang="ts"> <script setup lang="ts">
import { computed, defineAsyncComponent, defineComponent, nextTick, onMounted, reactive, ref, watch } from 'vue'; import { computed, defineAsyncComponent, nextTick, onMounted, ref, watch } from 'vue';
import { i18n } from '@/i18n'; import { i18n } from '@/i18n';
import MkInfo from '@/components/ui/info.vue'; import MkInfo from '@/components/ui/info.vue';
import MkSuperMenu from '@/components/ui/super-menu.vue'; import MkSuperMenu from '@/components/ui/super-menu.vue';
@ -34,33 +34,23 @@ import * as symbols from '@/symbols';
import { instance } from '@/instance'; import { instance } from '@/instance';
import { $i } from '@/account'; import { $i } from '@/account';
export default defineComponent({ const props = defineProps<{
components: { initialPage?: string
MkInfo, }>();
MkSuperMenu,
},
props: { const indexInfo = {
initialPage: {
type: String,
required: false
}
},
setup(props, context) {
const indexInfo = {
title: i18n.ts.settings, title: i18n.ts.settings,
icon: 'fas fa-cog', icon: 'fas fa-cog',
bg: 'var(--bg)', bg: 'var(--bg)',
hideHeader: true, hideHeader: true,
}; };
const INFO = ref(indexInfo); const INFO = ref(indexInfo);
const page = ref(props.initialPage); const page = ref(props.initialPage);
const narrow = ref(false); const narrow = ref(false);
const view = ref(null); const view = ref(null);
const el = ref(null); const el = ref<HTMLElement | null>(null);
const childInfo = ref(null); const childInfo = ref(null);
const menuDef = computed(() => [{ const menuDef = computed(() => [{
title: i18n.ts.basicSettings, title: i18n.ts.basicSettings,
items: [{ items: [{
icon: 'fas fa-user', icon: 'fas fa-user',
@ -103,7 +93,7 @@ export default defineComponent({
to: '/settings/security', to: '/settings/security',
active: page.value === 'security', active: page.value === 'security',
}], }],
}, { }, {
title: i18n.ts.clientSettings, title: i18n.ts.clientSettings,
items: [{ items: [{
icon: 'fas fa-cogs', icon: 'fas fa-cogs',
@ -131,7 +121,7 @@ export default defineComponent({
to: '/settings/plugin', to: '/settings/plugin',
active: page.value === 'plugin', active: page.value === 'plugin',
}], }],
}, { }, {
title: i18n.ts.otherSettings, title: i18n.ts.otherSettings,
items: [{ items: [{
icon: 'fas fa-boxes', icon: 'fas fa-boxes',
@ -164,7 +154,7 @@ export default defineComponent({
to: '/settings/other', to: '/settings/other',
active: page.value === 'other', active: page.value === 'other',
}], }],
}, { }, {
items: [{ items: [{
type: 'button', type: 'button',
icon: 'fas fa-trash', icon: 'fas fa-trash',
@ -183,10 +173,10 @@ export default defineComponent({
}, },
danger: true, danger: true,
},], },],
}]); }]);
const pageProps = ref({}); const pageProps = ref({});
const component = computed(() => { const component = computed(() => {
if (page.value == null) return null; if (page.value == null) return null;
switch (page.value) { switch (page.value) {
case 'accounts': return defineAsyncComponent(() => import('./accounts.vue')); case 'accounts': return defineAsyncComponent(() => import('./accounts.vue'));
@ -220,17 +210,17 @@ export default defineComponent({
case 'delete-account': return defineAsyncComponent(() => import('./delete-account.vue')); case 'delete-account': return defineAsyncComponent(() => import('./delete-account.vue'));
} }
return null; return null;
}); });
watch(component, () => { watch(component, () => {
pageProps.value = {}; pageProps.value = {};
nextTick(() => { nextTick(() => {
scroll(el.value, { top: 0 }); scroll(el.value, { top: 0 });
}); });
}, { immediate: true }); }, { immediate: true });
watch(() => props.initialPage, () => { watch(() => props.initialPage, () => {
if (props.initialPage == null && !narrow.value) { if (props.initialPage == null && !narrow.value) {
page.value = 'profile'; page.value = 'profile';
} else { } else {
@ -239,36 +229,24 @@ export default defineComponent({
INFO.value = indexInfo; INFO.value = indexInfo;
} }
} }
}); });
onMounted(() => { onMounted(() => {
narrow.value = el.value.offsetWidth < 800; narrow.value = el.value.offsetWidth < 800;
if (!narrow.value) { if (!narrow.value) {
page.value = 'profile'; page.value = 'profile';
} }
}); });
const emailNotConfigured = computed(() => instance.enableEmail && ($i.email == null || !$i.emailVerified)); const emailNotConfigured = computed(() => instance.enableEmail && ($i.email == null || !$i.emailVerified));
const pageChanged = (page) => { const pageChanged = (page) => {
if (page == null) return; if (page == null) return;
childInfo.value = page[symbols.PAGE_INFO]; childInfo.value = page[symbols.PAGE_INFO];
}; };
return { defineExpose({
[symbols.PAGE_INFO]: INFO, [symbols.PAGE_INFO]: INFO,
page,
menuDef,
narrow,
view,
el,
pageProps,
component,
emailNotConfigured,
pageChanged,
childInfo,
};
},
}); });
</script> </script>