From 132b01461d65e58508ab0206eddf09119bec46bd Mon Sep 17 00:00:00 2001 From: syuilo Date: Fri, 6 Oct 2023 16:10:59 +0900 Subject: [PATCH] refactor --- packages/backend/src/core/FeaturedService.ts | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/backend/src/core/FeaturedService.ts b/packages/backend/src/core/FeaturedService.ts index 89b86b2e30..78309e42e5 100644 --- a/packages/backend/src/core/FeaturedService.ts +++ b/packages/backend/src/core/FeaturedService.ts @@ -9,6 +9,8 @@ import type { MiNote } from '@/models/_.js'; import { DI } from '@/di-symbols.js'; import { bindThis } from '@/decorators.js'; +const GLOBAL_NOTES_RANKING_WINDOW = 1000 * 60 * 60 * 24 * 3; // 3日ごと + @Injectable() export class FeaturedService { constructor( @@ -26,7 +28,7 @@ export class FeaturedService { @bindThis private getCurrentGlobalNotesRankingWindow(): number { const passed = new Date().getTime() - new Date(new Date().getFullYear(), 0, 1).getTime(); - return Math.floor(passed / (1000 * 60 * 60 * 24 * 3)); // 3日ごと + return Math.floor(passed / GLOBAL_NOTES_RANKING_WINDOW); } @bindThis @@ -40,7 +42,7 @@ export class FeaturedService { noteId); redisTransaction.expire( `featuredGlobalNotesRanking:${currentWindow}`, - 60 * 60 * 24 * 9, // 9日間保持 + (GLOBAL_NOTES_RANKING_WINDOW * 3) / 1000, 'NX'); // "NX -- Set expiry only when the key has no expiry" = 有効期限がないときだけ設定 await redisTransaction.exec(); } @@ -55,7 +57,7 @@ export class FeaturedService { noteId); redisTransaction.expire( `featuredInChannelNotesRanking:${channelId}:${currentWindow}`, - 60 * 60 * 24 * 9, // 9日間保持 + (GLOBAL_NOTES_RANKING_WINDOW * 3) / 1000, 'NX'); // "NX -- Set expiry only when the key has no expiry" = 有効期限がないときだけ設定 await redisTransaction.exec(); }